Skip to content

Comments

refactor: clean up ShareService a little#2333

Merged
blizzz merged 1 commit intomainfrom
fix/noid/cleanup-share-handling
Feb 18, 2026
Merged

refactor: clean up ShareService a little#2333
blizzz merged 1 commit intomainfrom
fix/noid/cleanup-share-handling

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Feb 18, 2026

  • make class properties readonly private
  • clean up imports
  • clean up PHP doc
  • remove unnecessary vars
  • better naming of attribute

@blizzz blizzz requested a review from enjeck as a code owner February 18, 2026 11:03
@blizzz blizzz added technical debt Technical issue 3. to review Waiting for reviews labels Feb 18, 2026
- make class properties readonly private
- clean up imports
- clean up PHP doc
- remove unnecessary vars

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/noid/cleanup-share-handling branch from db157e8 to 4b58d85 Compare February 18, 2026 11:08
@blizzz blizzz merged commit d4843f1 into main Feb 18, 2026
62 of 65 checks passed
@blizzz blizzz deleted the fix/noid/cleanup-share-handling branch February 18, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants